Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler crash on typecheck error in FFI call. #2124

Merged
merged 2 commits into from
Aug 3, 2017

Conversation

charlesetc
Copy link
Contributor

Running this build of ponyc on the code I posted in this issue #2114 results in a type error instead of a core dump.

Error:
/home/charles/code/stars/bindings.pony:13:21: can't take the address of a let local
    @glutInit[None](addressof argc, argv)

Is return false all that's needed?

@jemc
Copy link
Member

jemc commented Aug 2, 2017

Thank you!

Is return false all that's needed?

Yep, that's the appropriate course of action in this situation.


Can you also add a regression test to https://github.com/ponylang/ponyc/blob/master/test/libponyc/badpony.cc that includes the test case from #2114?

@jemc jemc added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Aug 2, 2017
@charlesetc
Copy link
Contributor Author

Yep! Thanks 🍏

@jemc jemc changed the title Type error check for ffi statement Fix compiler crash on typecheck error in FFI call. Aug 3, 2017
@jemc jemc merged commit f313e85 into ponylang:master Aug 3, 2017
ponylang-main added a commit that referenced this pull request Aug 3, 2017
@jemc
Copy link
Member

jemc commented Aug 3, 2017

Thanks for taking care of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants