Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile error for generic Main #1970

Merged
merged 2 commits into from
Jun 19, 2017
Merged

Add compile error for generic Main #1970

merged 2 commits into from
Jun 19, 2017

Conversation

Theodus
Copy link
Contributor

@Theodus Theodus commented Jun 18, 2017

This PR adds a compile error for a Main actor with type parameters.

closes #1936

@jemc
Copy link
Member

jemc commented Jun 19, 2017

What do you think about moving this check to the syntax_entity function in pass/syntax.c? There are some closely related checks there, such as enforcing that Main must be an actor, and enforcing that C API actors do not have type parameters.

@Theodus
Copy link
Contributor Author

Theodus commented Jun 19, 2017

@jemc seems reasonable, I'll try

@Theodus Theodus added the do not merge This PR should not be merged at this time label Jun 19, 2017
@Theodus Theodus removed the do not merge This PR should not be merged at this time label Jun 19, 2017
@Theodus
Copy link
Contributor Author

Theodus commented Jun 19, 2017

@jemc the check has been moved to the syntax pass.

@jemc
Copy link
Member

jemc commented Jun 19, 2017

Thanks!

The appveyor CI failure was unrelated, so I'm merging.

@jemc jemc added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Jun 19, 2017
@jemc jemc merged commit becc228 into ponylang:master Jun 19, 2017
ponylang-main added a commit that referenced this pull request Jun 19, 2017
@Theodus Theodus deleted the issue-1936 branch August 6, 2017 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed assertion during codegen with generic Main
2 participants