Fix type parameters not being visible to a lambda type in a type alias #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemc
requested changes
Mar 4, 2017
test/libponyc/verify.cc
Outdated
|
|
||
| TEST_F(VerifyTest, LambdaTypeGenericAliased) | ||
| { | ||
| const char *good = |
There was a problem hiding this comment.
To be consistent with the other tests, could you use src as the name of the variable that holds the string for this source code, rather than good?
test/libponyc/verify.cc
Outdated
| TEST_F(VerifyTest, LambdaTypeGenericAliased) | ||
| { | ||
| const char *good = | ||
| "type Foo[T] is { (T): T }"; |
There was a problem hiding this comment.
To be consistent with the lambda type style used in other tests, could you remove the "extra" spaces inside the curly braces. That is, it would be consistent if it looked like: {(T): T}.
There was a problem hiding this comment.
Ok, I have updated the commit.
|
Nice! |
sylvanc
approved these changes
Mar 4, 2017
sylvanc
added
the
changelog - fixed
ponylang-main
added a commit
that referenced
this pull request
Mar 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the following code does not compile:
The compiler gives the error:
This PR allows the lambda type to find type parameters from an enclosing type alias, as well as class, actor, etc.
I don't think this should affect anything else, since the only other use of the
collect_type_params()function is for sugaring object literals, which aren't allowed in a type alias. Please let me know if this change will have wider implications.