CodegenIdentityTest.DigestofObject failure on 32bit archs

[lgbaldoni]

i586 and armv7l on 0.11.4.

[ RUN      ] CodegenIdentityTest.DigestofObject
test/libponyc/codegen_identity.cc:184: Failure
Value of: 1
Expected: exit_code
Which is: 0
[  FAILED  ] CodegenIdentityTest.DigestofObject (23 ms)

Is there a way to test this interactively?

[Praetonus]

Could you change the test to this to see the values:

TEST_F(CodegenIdentityTest, DigestofObject)
{
  const char* src =
    "actor Main\n"
    "  new create(env: Env) =>\n"
    "    let dg = digestof env\n"
    "    let addr = @ptr_to_int[ISize](env).u64()\n"
    "    if dg == addr then\n"
    "      @pony_exitcode[None](I32(1))\n"
    "    else\n"
    "      env.out.print(dg.string())\n"
    "      env.out.print(addr.string())\n"
    "    end";

  set_builtin(NULL);

  TEST_COMPILE(src);

  int exit_code = 0;
  ASSERT_TRUE(run_program(&exit_code));
  ASSERT_EQ(exit_code, 1);
}

We probably need a better way to report failures in tests executing Pony programs. I'll look into what's possible.

[lgbaldoni]

[ RUN      ] CodegenIdentityTest.DigestofObject
2708146176
18446744072122730496
test/libponyc/codegen_identity.cc:189: Failure
Value of: 1
Expected: exit_code
Which is: 0
[  FAILED  ] CodegenIdentityTest.DigestofObject (1109 ms)

[Praetonus]

So in hexadecimal, that's A16B0800 and FFFFFFFFA16B0800.

This comes from the cast to intptr_t in ptr_to_int. Since it's a cast to a signed integer type, it does sign extension. The fix is to use uintptr_t. I'll open a PR.

Thanks for reporting.

[lgbaldoni]

Works for me.

[Praetonus]

Good. I'll merge the PR then.