Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to handle new ProcessError types #89

Merged
merged 2 commits into from
May 3, 2020
Merged

Conversation

chalcolith
Copy link
Member

@chalcolith chalcolith commented May 1, 2020

The ProcessError types from the stdlib process package now store their own error messages.

Fixes #88.

The `ProcessError` types from the stdlib `process` package now store their own error messages.
@chalcolith chalcolith added changelog - changed Automatically add "Changed" CHANGELOG entry on merge do not merge This PR should not be merged at this time labels May 1, 2020
@chalcolith
Copy link
Member Author

Needs to wait until the ponyc PR ponylang/ponyc#3532 is merged.

@SeanTAllen SeanTAllen removed the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label May 3, 2020
@SeanTAllen
Copy link
Member

@kulibali no changelog entry is needed for this as it isnt a user facing change.

@SeanTAllen
Copy link
Member

@kulibali can you bump this so CI runs against with updated ponyc?

@SeanTAllen
Copy link
Member

@kulibali it failed because the "release" ci image is one that gets built daily with additional tools installed. I'm updating it now.

@SeanTAllen
Copy link
Member

@kulibali image updated. i restarted the jobs.

@SeanTAllen
Copy link
Member

Passed. Merging.

@SeanTAllen SeanTAllen merged commit 58baf1e into master May 3, 2020
@SeanTAllen SeanTAllen deleted the processerror_update branch May 3, 2020 15:18
@SeanTAllen SeanTAllen removed the do not merge This PR should not be merged at this time label May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to support Pony 0.34.0
2 participants