This repository was archived by the owner on Sep 20, 2022. It is now read-only.
Persist configuration unconditionally with CreateOrUpdate() #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisgroth
force-pushed
the
smarter_config_save
branch
from
f4879a9 to
2edd6e0
Compare
travisgroth
requested review from
a team,
calebdoxsey and
desimone
and removed request for
a team
Remove logic to track our updates and, instead, rely on controller-runtime's CreateOrUpdate() logic to handle diffing. The result is that we will ensure the persisted config is up to date every settlePeriod seconds. Signed-off-by: Travis Groth <[email protected]>
travisgroth
force-pushed
the
smarter_config_save
branch
from
2edd6e0 to
a47e1fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 75.16% 75.33% +0.17%
==========================================
Files 7 7
Lines 447 442 -5
==========================================
- Hits 336 333 -3
+ Misses 80 78 -2
Partials 31 31
Continue to review full report at Codecov.
|
desimone
reviewed
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove logic to track our updates and, instead, rely on controller-runtime's
CreateOrUpdate() logic to handle diffing. The result is that we will
ensure the persisted config is up to date every settlePeriod seconds.