refactor(rust): Add updated multiscan pipeline #21925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
nameexhaustion
commented
Mar 26, 2025
| @@ -75,8 +77,10 @@ impl ApplyExtraOps { | |||
| scan_source_idx, | |||
| hive_parts, | |||
| } => { | |||
| // This should always be pushed to the reader, or otherwise handled separately. | |||
| assert!(pre_slice.is_none()); | |||
| // Negative slice should have been resolved earlier. | |||
There was a problem hiding this comment.
Added support for slice in post-apply, as external readers may not support ReaderCapabilities::PRE_SLICE.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21925 +/- ##
==========================================
- Coverage 80.83% 80.46% -0.37%
==========================================
Files 1629 1635 +6
Lines 235097 236228 +1131
Branches 2693 2693
==========================================
+ Hits 190039 190080 +41
- Misses 44424 45515 +1091
+ Partials 634 633 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
nameexhaustion
force-pushed
the
multi-file-pipeline
branch
from
422ee66 to
0396e3c
Compare
coastalwhite
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains an updated multiscan pipeline implementation. This is not hooked up yet - it is currently missing the IR lowering and refactoring of the individual readers to use the updated pipeline.
Some improvements include:
<T: MultiScanable>withdyn FileReaderReaderCapabilities(slice/predicate)row_position_on_endThe effects of these optimizations differ across file types - I will have more concrete benchmark numbers for them per file type in follow-up PRs.
@coastalwhite