fix(middleware): match vanilla StateCreator type in subscribeWithSelector

[toddw]

Match

zustand/src/vanilla.ts

Lines 50 to 52 in 0ba3c24

	CustomSetState = SetState<T>,
	CustomGetState = GetState<T>,
	CustomStoreApi extends StoreApi<T> = StoreApi<T>

to make subscribeWithSelector more useful with custom states.

Ran into this when trying to use subscribeWithSelector with
custom middleware that uses immer's WritableDraft on SetState

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e39b1ed:

Sandbox	Source
React	Configuration
React Typescript	Configuration
React Browserify	Configuration
React Snowpack	Configuration
React Parcel	Configuration
Next.js	Configuration

[dai-shi]

@devanshj Does this conflict with v3.7.0 and v4?

[devanshj]

It does “conflict” with v4 but there already is a conflict without this too, and it won't hurdle with v3.7.0 as it's not changing much.

But the issue I find here is it'd make sense for all middlewares to have similar type, so if you think this is a good change the same change should be made to other middlewares too.

[dai-shi]

@toddw I think it's a rare case that you need to specify only one type to subscribeWithSelector. What's your case?
Do you want to make this change and maybe others, if this is going to live only for a short period?

[dai-shi]

I made changes for all middlewares. Let's merge this for v3.7.0.

[toddw]

Looks great! Thanks for updating it