Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): Refactor demo code to reduce distraction from Zustand usage #751

Merged
merged 3 commits into from
Jan 13, 2022
Merged

chore(examples): Refactor demo code to reduce distraction from Zustand usage #751

merged 3 commits into from
Jan 13, 2022

Conversation

DanielPower
Copy link
Contributor

Based on my comment here: #747 (comment)

This simply pulls much of the design code out into separate files, so that App.js has a clearer focus on declaring the store and implementing the counter.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 258e2dd:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

@dai-shi
Copy link
Member

dai-shi commented Jan 13, 2022

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the refactor!

@dai-shi dai-shi changed the title Refactor demo code to reduce distraction from Zustand usage chore(examples): Refactor demo code to reduce distraction from Zustand usage Jan 13, 2022
@dai-shi dai-shi merged commit 0ba3c24 into pmndrs:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants