-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): use TS interfaces only for public api #1106
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a9a05f7:
|
Size Change: -1 B (0%) Total Size: 28.8 kB
ℹ️ View Unchanged
|
@dai-shi i'm wondering why interface is preffered over types for external public api |
for complex types, type aliases will be inlined, which doesn't look nice. See screenshot in pmndrs/jotai#1234 for example. |
@dai-shi would this be released soon? any timeline? thanks 🙏🏾 |
It's already released. |
This mostly reverts #1012.
@typescript-eslint/consistent-type-definitions
rule doesn't work for library code.So, our new ground rule is:
export
)close #1100
close #1103
close #1113
jotai and valtio should follow this too.