-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bindings to compile under multiple node versions #3
base: master
Are you sure you want to change the base?
Conversation
Hmm. Since this completely breaks the build on Node < 0.12 (which I should have probably anticipated) I am going to close this for now. Going to take a crack at updating it to use nan instead which I believe should handle the differences between versions. |
Ok, redid this using nan. All tests are green on my build, hoping this fares better on Node < 0.12 |
+1 merge this in! |
I actually just got an error
|
This PR is to support Node v0.12 . You are building on Node v5.0.0 |
v8 0.12 has a number of breaking changes, and this module can no longer be installed on many systems which default to node 0.12+
I updated it to the current API. It compiles on Node v0.12.5. All tests pass.
Fixes #2