-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specialized tla+ for RaftRs #43
base: master
Are you sure you want to change the base?
Conversation
PTAL @overvenus @tonyxuqqi |
RaftRs/.gitignore
Outdated
@@ -0,0 +1,2 @@ | |||
states | |||
*.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll do now
RaftRs/consensus/UdpNetwork.tla
Outdated
(*************************************************************************** | ||
API NetGetMsg: Get msg from src -> dst FIFO head | ||
* return msg m | ||
真的需要实现吗?? 讨论 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please tidy up the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i'll do now
Hi, is there anything else I should add, and if so, can you let me know and I'll change it? |
/\ nextIndex \in [ Servers -> [ Servers -> Nat \ {0} ]] | ||
/\ matchIndex \in [ Servers -> [ Servers -> Nat ]] | ||
|
||
\* TypeOkCandidateVars == |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why comment out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an uncleared comment. I'll clear it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems it's still not cleared @wego1236
PTAL @BusyJay |
@wego1236 friendly ping |
I'm sorry I've been on hold for so long because I had something come up a while ago and I've reworked it, can you guys take a look at it again? |
@wego1236 Will take a look later |
If there is a problem, you can tell me and I'll fix it in time. |
Hello, I'd like to ask if there's anything I can push forward with |
Seems this PR don't contain this change tikv/raft-rs@3cfa667 @wego1236 would you mind to add it? |
I'm going to study it and make changes |
I'm sorry for taking so long to reply. |
LGTM overall, PTAL @zhangjinpeng87 |
What else do I need to do? This is related to my graduation.I need to finish writing my graduation thesis and defend it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @zhangjinpeng87 |
We've made a formal specification for Raft in paper "In Search of an Understandable Consensus Algorithm" and a certain scale of model checking to verify the correctness of raft-rs(currently still running). There may exist differences between our specification and Raft in paper or in implementation. Please let us know flaws of specification if you have any question.