Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storages: add DMFile & ColumnFileTiny & Segment inverted index reader #10006

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Storages: add DMFile & ColumnFileTiny & Segment inverted index reader #10006

wants to merge 6 commits into from
+1,493 −35

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Mar 17, 2025 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: ref #9843

Problem Summary:

What is changed and how it works?

Part 3 of of inverted index, introduce `InvertedIndexReaderFromDMFile`, `InvertedIndexReaderFromColumnFileTiny` and `InvertedIndexReaderFromSegment`.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 17, 2025
@Lloyd-Pottiger Lloyd-Pottiger force-pushed the add-inverted-index-reader branch from f585ba2 to 9074280 Compare March 17, 2025 02:26
@Lloyd-Pottiger Lloyd-Pottiger changed the title Add inverted index reader Storages: add DMFile & ColumnFileTiny & Segment inverted index reader Mar 17, 2025
@Lloyd-Pottiger Lloyd-Pottiger mentioned this pull request Mar 18, 2025
Merged
12 tasks
@Lloyd-Pottiger Lloyd-Pottiger force-pushed the add-inverted-index-reader branch from 9074280 to 080d1e3 Compare March 24, 2025 02:02
@Lloyd-Pottiger Lloyd-Pottiger force-pushed the add-inverted-index-reader branch from 080d1e3 to 95b3f2e Compare March 24, 2025 08:20
JinheLin
JinheLin reviewed Mar 25, 2025
View reviewed changes
dbms/src/Storages/DeltaMerge/Index/InvertedIndex/Reader/ReaderFromDMFile.cpp
Comment on lines +115 to +118
if ( //
PerfContext::file_cache.fg_download_from_s3 > perf_begin.fg_download_from_s3 || //
PerfContext::file_cache.fg_wait_download_from_s3 > perf_begin.fg_wait_download_from_s3)
has_s3_download = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statistical method seems a bit odd, and it might lead to inaccuracies due to concurrency. Why not have the downloadFileForLocalRead function return whether the cache was hit or not?

breezewish
breezewish reviewed Mar 25, 2025
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good, very similar to Vector's stream and reader.

JinheLin
JinheLin reviewed Mar 25, 2025
View reviewed changes
dbms/src/Storages/DeltaMerge/Index/InvertedIndex/Reader/ReaderFromDMFile.cpp
Comment on lines +94 to +113
// If download file failed, retry a few times.
for (auto i = 3; i > 0; --i)
{
try
{
if (auto file_guard = file_cache->downloadFileForLocalRead(s3_file_name, index_props.file_size());
file_guard)
{
local_index_file_path = file_guard->getLocalFileName();
break; // Successfully downloaded index into local cache
}

throw Exception(ErrorCodes::S3_ERROR, "Failed to download vector index file {}", index_file_path);
}
catch (...)
{
if (i <= 1)
throw;
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encapsulate these retry logics within the file cache.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will refine this in another PR.

@Lloyd-Pottiger
address comments
37fc0f7 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
address comments
bb8bfc3 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
address comments
4e2fa24 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
address comments
6b97063 
Signed-off-by: Lloyd-Pottiger <[email protected]>
CalvinNeo
CalvinNeo approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 26, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-26 06:56:51.349360651 +0000 UTC m=+1029905.033596732: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 26, 2025
JaySon-Huang
JaySon-Huang reviewed Mar 26, 2025
View reviewed changes
dbms/src/Storages/DeltaMerge/Index/InvertedIndex/Reader/ReaderFromSegment.cpp
Comment on lines +70 to +73
else
{
bitmap_filter->append(BitmapFilter(cf->getRows(), true));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are ColumnFileBig with inverted index, now we can not utilize the inverted index in ColumnFileBig?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will not build index for ColumnFileBig now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to apply a filter afterward?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bitmap filter should be the same size of MVCC bitmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish left review comments

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@JinheLin JinheLin JinheLin left review comments

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees
No one assigned
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lloyd-Pottiger @breezewish @JaySon-Huang @CalvinNeo @JinheLin