Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix multi_topics test #1058

Merged
merged 5 commits into from
Mar 4, 2025
Merged

test: fix multi_topics test #1058

merged 5 commits into from
Mar 4, 2025

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Feb 28, 2025

What problem does this PR solve?

Issue Number: ref #442

What is changed and how it works?

  1. send checkpointTs to previous table after renaming table.
  2. fix topic generator about hard code rule.
  3. auto create topic when topic does not exist.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Copy link

ti-chi-bot bot commented Feb 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2025
@wk989898 wk989898 marked this pull request as ready for review February 28, 2025 09:14
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2025
Copy link

ti-chi-bot bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 4, 2025
Copy link

ti-chi-bot bot commented Mar 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-04 06:04:49.077574753 +0000 UTC m=+335202.206494495: ☑️ agreed by 3AceShowHand.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 4, 2025
@ti-chi-bot ti-chi-bot bot merged commit e1bb2cd into pingcap:master Mar 4, 2025
10 of 12 checks passed
@wk989898 wk989898 deleted the topics branch March 4, 2025 06:14
hongyunyan pushed a commit to hongyunyan/tigate that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants