Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR]: Add a method that describes an exception to HTML format #14794

Closed
TimurFlush opened this issue Jan 31, 2020 · 4 comments
Closed

[NFR]: Add a method that describes an exception to HTML format #14794

TimurFlush opened this issue Jan 31, 2020 · 4 comments
Labels
new feature request Planned Feature or New Feature Request

Comments

@TimurFlush
Copy link

TimurFlush commented Jan 31, 2020

Hello!

The Phalcon\Debug class now generates an HTML view with every new exception.

My idea is to add public method renderHtml(\Throwable $ex): string.
That is, the class work will not change, but developers can use this method in their solutions to generate HTML representation as a string.
For example, the developer does not want to use the standard mechanism of catching exceptions which provides Phalcon, and wants just to receive HTML representation from this mechanism as a string.

Thanks.
I'm waiting for feedback.

@TimurFlush TimurFlush added the new feature request Planned Feature or New Feature Request label Jan 31, 2020
@TimurFlush TimurFlush changed the title [NFR]: Add a method that describes an exception to HTML/JSON format [NFR]: Add a method that describes an exception to HTML format Jan 31, 2020
@TimurFlush
Copy link
Author

TimurFlush commented Jan 31, 2020

I created a new method renderHtml() in the Phalcon\Debug class.
I just tested it, and it's working fine.
Can I create a PR?

@niden Please see

@Jurigag
Copy link
Contributor

Jurigag commented Jan 31, 2020

Feel free to always create PR if you want, you don't have to ask for permission @TimurFlush :)

@niden niden added the 4.1.0 label Feb 5, 2020
niden pushed a commit that referenced this issue Feb 5, 2020
niden pushed a commit that referenced this issue Feb 5, 2020
niden pushed a commit that referenced this issue Feb 5, 2020
@niden
Copy link
Member

niden commented Feb 5, 2020

Thank you @TimurFlush

Resolved in #14812

@niden niden closed this as completed Feb 5, 2020
@TimurFlush
Copy link
Author

Thank you @TimurFlush

Resolved in #14812

And you (:

@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature request Planned Feature or New Feature Request
Projects
Archived in project
Development

No branches or pull requests

3 participants