Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make GenerationOptions deserializable #28

Merged
merged 1 commit into from
Feb 25, 2024
Merged

feat: make GenerationOptions deserializable #28

merged 1 commit into from
Feb 25, 2024

Conversation

AlexisTM
Copy link
Contributor

Having the GenerationOptions deserializable allows for the options to be loaded at runtime.

@pepperoni21 pepperoni21 merged commit 01db8f6 into pepperoni21:master Feb 25, 2024
1 of 2 checks passed
@dezoito
Copy link
Contributor

dezoito commented Feb 25, 2024

@AlexisTM , can you post an example on how you are loading them at runtime after this commit?

@AlexisTM AlexisTM deleted the feat/make_generation_options_deserializable branch February 26, 2024 08:05
@AlexisTM AlexisTM restored the feat/make_generation_options_deserializable branch February 26, 2024 08:05
@AlexisTM AlexisTM mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexisTM @dezoito @pepperoni21