Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subject and ref bug #1506

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Fix subject and ref bug #1506

merged 3 commits into from
Mar 17, 2025

Conversation

CTY-git
Copy link
Contributor

@CTY-git CTY-git commented Mar 17, 2025

PR Checklist

  • The commit message follows our guidelines: Code of conduct
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Does this PR introduce a breaking change?
  • Include PR in release notes?

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Build /CI
  • Documentation
  • Others

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@CTY-git CTY-git requested a review from whoisarpit March 17, 2025 08:55
@patched-admin
Copy link
Contributor

File Changed: patchwork/steps/SendEmail/SendEmail.py

Rule 1: Do not ignore potential bugs in the code
Details: Identified a bug correction rather than a bug introduction. The change fixes RFC compliance by correcting the email header from "Reference" to "References". This is actually a bug fix as the correct header name according to RFC 2822 is "References" (plural).

Affected Code Snippet:

msg.add_header("Reference", self.reply_message_id)  # Before
msg.add_header("References", self.reply_message_id) # After

Start Line: N/A
End Line: N/A

@CTY-git CTY-git merged commit 4b54119 into main Mar 17, 2025
4 checks passed
@CTY-git CTY-git deleted the fix-email-subject-and-ref-bug branch March 17, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants