Include dtype information #35
Conversation
|
Looking cool...I still need to think about how I'd viz this. Maybe the elem type goes in the box not outside, for example. |
|
Discussion on that could go in the issue. With respect to implementation: this feature still needs testing, mention in documentation/examples. |
|
Failing tests seem unrelated. Two examples to for review.
|
|
Ok, took me a second, but I managed to find a combination of versions that make the tests pass (python 3.9)! @sbrugman you can pull from master to grab these |
|
Ready for review, legend improved over the last time we spoke |
|
sounds good @sbrugman ... I am writing my final exam and hoping to catch up shortly... |
|
Trying it out now :) |
| return head, tail | ||
|
|
||
| def _get_dtype_color_indices(self, dtype_name, dtype_precision): | ||
| if dtype_name not in self._dtype_name2color: |
There was a problem hiding this comment.
it looks like base color can change for same type depending on order in which this function is called, right?
There was a problem hiding this comment.
I'll assign a specific color like "greenish" to floats or whatever.
There was a problem hiding this comment.
BTW, i'm altering in a copy of your branch so i'll take a whack at fixing. I've made some changes like "no old style shape colors".
There was a problem hiding this comment.
Ok I'm thinking we specify a fixed color per type then bit size is gradation for 4, 8, 16, 32, 64, 128 (auto computed with color map). I'm looking at types for various packages.
|
I have to clean up AST viz but about ready! Thanks for the help! |
Closes #25