Fix error after setting view zoom #1558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure view matrix is invertible by restricting zoom allowed values. Convert extremely low, null and extremely high value, to the nearest possible value. Closes paperjs#1433
sasensi
force-pushed
the
fix/error-after-setting-view-zoom
branch
from
e648740 to
e874e35
Compare
lehni
force-pushed
the
develop
branch
2 times, most recently
from
3cc7fa3 to
a9ebe47
Compare
sapics
approved these changes
Jun 11, 2020
lehni
force-pushed
the
develop
branch
2 times, most recently
from
39b63a1 to
b90a711
Compare
lehni
force-pushed
the
develop
branch
3 times, most recently
from
4a6bf6f to
0f4afc5
Compare
|
This could have been merged? Seems to be a great fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure view matrix is invertible by restricting zoom allowed values.
Convert extremely low, null and extremely high value, to the nearest possible value.
Based on this idea #1433 (comment).
Related issues
Checklist
npm run jshintpasses)