Bump to zinc 1.0.3 #5049
Merged
Bump to zinc 1.0.3 #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwlzn
approved these changes
Nov 3, 2017
| @@ -21,7 +21,7 @@ jar_library( | |||
| jars=[ | |||
| # TODO: `zinc` only declares a dep on the `tests` classifier for | |||
| # util-logging for some reason. We redefine the dep here to get the full package. | |||
| scala_jar(org='org.scala-sbt', name='util-logging', rev='1.0.0-RC3', force=True), | |||
| scala_jar(org='org.scala-sbt', name='util-logging', rev='1.0.0', force=True), | |||
There was a problem hiding this comment.
these shouldn't also bump to 1.0.3?
There was a problem hiding this comment.
No: they are versioned independently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#4729 is currently blocked on the fix for sbt/zinc#389, which is now released in zinc
1.0.3.Solution
Bump to zinc 1.0.3 to pick up that fix.