✨ Remove explorer-views index #4714
Draft
+27
−490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
force-pushed
the
drop-explorer-views-index
branch
from
f0296cd to
d0b00d9
Compare
ikesau
commented
Mar 28, 2025
| @@ -84,7 +84,7 @@ $reset-button-margin: 16px; | |||
| border-bottom: 1px solid $blue-10; | |||
| display: flex; | |||
| flex-wrap: nowrap; | |||
| overflow-x: scroll; | |||
| overflow-x: auto; | |||
There was a problem hiding this comment.
This fixes a small issue I noticed on safari on small screens
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-03-28 19:07:20 UTC |
ikesau
force-pushed
the
drop-explorer-views-index
branch
from
d0b00d9 to
79c7276
Compare
ikesau
force-pushed
the
drop-explorer-views-index
branch
from
79c7276 to
af01172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Removes the
explorer-viewsindex and the Explorers section in search, in favour of using theexplorer-views-and-chartsindex everywhere.Screenshots / Videos / Diagrams
no.explorer.views.section.on.search.mp4
Testing guidance
Go to http://staging-site-drop-explorer-views-index/search and try finding charts and explorer views.
Checklist
Before merging