Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix margin of Button without icon #4713

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Fix margin of Button without icon #4713

merged 1 commit into from
Mar 28, 2025

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Mar 28, 2025

Context

When we recently changed how icons in Button work, we introduced this additional margin when there is no icon.

Screenshots / Videos / Diagrams

image

@rakyi rakyi requested a review from ikesau March 28, 2025 16:38
ikesau
ikesau approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

thanks! tested all 3 permutations and it works correctly, finally 😅

@owidbot
Copy link
Contributor

owidbot commented Mar 28, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-fix-button-icon-margin

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-03-28 17:02:49 UTC
Execution time: 1.29 seconds

@rakyi rakyi merged commit 2205eed into master Mar 28, 2025
40 checks passed
@rakyi rakyi deleted the fix-button-icon-margin branch March 28, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikesau ikesau ikesau approved these changes

Assignees

@rakyi rakyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakyi @owidbot @ikesau