Tweak data page header #4704
Merged
Tweak data page header #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyi
force-pushed
the
tweak-data-page-header
branch
from
05a12ee to
e2ad751
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-03-27 14:23:40 UTC |
rakyi
force-pushed
the
tweak-data-page-header
branch
2 times, most recently
from
6f2e982 to
31d682f
Compare
ikesau
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Nice! Looking a lot better.
Once Marwa's approved this I think we can go ahead (i left one tiny comment)
Though while testing, I noticed a positioning/cropping issue with these dropdowns on mobile (present on master atm, so not a regression)
Up to you if you wanna tackle that here also 🙂
mdim.dropdown.on.mobile.mov
* Implement original mobile design typography * Fix spacing in multidimensional data page
rakyi
force-pushed
the
tweak-data-page-header
branch
from
31d682f to
f8c1a68
Compare
37 tasks
|
Well spotted, added the dropdown overflow to #3874. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by Marwa.
Fixes #4232