Enable caching #383
Merged
Enable caching #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS-ovm
reviewed
Jun 11, 2024
There was a problem hiding this comment.
The only thing I remember is that for a time actions/setup-go and golangci/golangci-lint-action caching implementation conflicted but this job isn't using golangci.
I've checked the history and the action runs around the time #202 was committed and merged, and that was the day(s) you were working on the initial homebrew release. The CI logs are already lost in time.
Especially today I would be conservative and merge it only after the release.
|
As discussed in call, go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any idea why this isn't on? I'm the one that turned it off: #202 But I can't for the life of me remember why. Any ideas @DavidS-ovm?