Add Zoom Navigation Control to the map #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zooming on a desktop is not a problem, but on a touch device one is helpless without the NavigationControls which are added here. Documentation: Example https://docs.mapbox.com/mapbox-gl-js/example/navigation/ Config https://docs.mapbox.com/mapbox-gl-js/api/#navigationcontrol
|
@willemarcel why you are active here (#202), I would love to see those zoom controls in the app to improve the mobile and iPad experience. |
|
Merged with #204 |
|
Thank you very much, @tordans ! Sorry for the delay... I added a check to show the zoom control only if the device is touchscreen and doesn't have a mouse. We'll update osmcha tomorrow. Let me know if it works for you |
|
@tordans it's already live on osmcha.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zooming on a desktop is not a problem, but on a touch device one is helpless without the NavigationControls which are added here.
Documentation:
Example https://docs.mapbox.com/mapbox-gl-js/example/navigation/
Config https://docs.mapbox.com/mapbox-gl-js/api/#navigationcontrol
I could not test this locally. I have the system active now, but the bundle.js is not refreshed on my system, so the changes in this file never showed in my browser. However, its a simple change so I hope it will just work. Please test it before considering a merge.
This is a step to improve OSMCha/osmcha-frontend#341 once it is added to the osmcha-frontend.