feat: provide pgx logging wrapper #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezr-ondrej
approved these changes
Mar 18, 2025
| @@ -137,6 +137,9 @@ var handlerMulti *strc.MultiHandler | |||
| var handlerSplunk *splunk.SplunkHandler | |||
| var handlerCloudWatch *cloudwatchwriter2.Handler | |||
|
|
|||
| // The main logger instance. Use InitializeLogging to create it. | |||
| var logger *slog.Logger | |||
There was a problem hiding this comment.
do we need to have global logger instance?
Sounds like it's just for pgx, could we avoid it ?
|
I just realized that PGX provides tracing capabilities and logging is subset of tracing, so this is actually not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a function which returns a wrapper that can be used for pgx SQL driver logging:
Most projects do use pgx driver so I thought it will be useful to have it in the library. Unfortunately pulls few dependencies in as the interface is designed in a way it requires a constant from the
pgxpackage so it cannot be copied.