feat(core): property sorting #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllieJonsson
commented
Dec 21, 2024
Comment on lines
+74
to
+75
| const entries = Object.entries(item.properties); | ||
| if (context.output.propertySortOrder === PropertySortOrder.ALPHABETICAL) { |
There was a problem hiding this comment.
This is the only difference here, the rest is just whitespace changes
melloware
previously approved these changes
Dec 21, 2024
anymaniax
reviewed
Dec 22, 2024
|
That's a good improvement. |
|
Ill change the default to be Specification instead! |
soartec-lab
approved these changes
Dec 23, 2024
melloware
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY/HOLD
Description
Fixes #1737
Not sure if this is a good way to go, ordering of properties seems irrelevant in the end (no functionality difference), so I'm not sure if this is what we want. I'll let you Maintainers decide :)
Todos