feat: store language code of the consent in the cookie #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for cookieconsentv3-playground canceled.
|
|
LGTM, thanks for the contribution! |
Thanks and happy new year to you! Any estimate when you plan next CookieConsent release? |
|
@OndraM sorry for the late reply, should be up by the end of the week! |
Great, we are waiting for this release :) . Thank you! |
|
@orestbida Sorry for reminding this, I very well know you do this in your free time, but do you have any ETA? We are depending on the change and its release and its blocking us right now. 😞 Thanks for your work! |
|
sorry for the delay, had forgotten ... done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use cookieconsent library with many languages on multi-lingual site. Because of that, is it important information for us to be able to know the language of the consent the user has given.
This is useful in callbacks (as we store the consent meta data including language also server-side) and also when reading the language code from the already given consent cookie.
This PR extends cookie data with languageCode property. The property is only stored in the cookie, and its use is completely up to library users - its not populated back to cookieconsent global state etc.