Skip to content
This repository was archived by the owner on Jul 8, 2021. It is now read-only.

Update Measure variable names to meet PEP8 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rstarmer
Copy link
Contributor

@rstarmer rstarmer commented Jan 8, 2020

Metrics names were re-worked to be PEP8 compliant as they
are leveraged when defining performance management interactions
and so need to be valid Python variables. The #TODO was also
removed

Metrics names were re-worked to be PEP8 compliant as they
are levarged when defining performance management interactions
and so need to be valide Python variables.  The #TODO was also
removed
@rstarmer
Copy link
Contributor Author

rstarmer commented Jan 8, 2020

@pnickolov @ekalosak Can you please review and merge if acceptable.

@ekalosak
Copy link

ekalosak commented Jan 8, 2020

lgtm, converted spaces to underscores, a win in my book.

@pavel-georgiev
Copy link

Not sure what you mean by performance management interactions , but if you are trying to use these in formulas, you can use metrics['my_metric'] instead of my_metric.

@rstarmer
Copy link
Contributor Author

rstarmer commented Jan 8, 2020

@pavel-georgiev That is what I meant, and I wasn't aware of the array name being returned. I still think this is easier, especially for someone wanting to work with a single parameter.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants