-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/user config handling and performance fixes #2856
base: feat/make-classification-and-criticality-optional
Are you sure you want to change the base?
Chore/user config handling and performance fixes #2856
Conversation
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
0a59632
to
0f3855f
Compare
tests showed: electron-settings do not reliably update if multiple updates are pending at the same time Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
src/ElectronBackend/main/__tests__/user-settings-provider.test.ts
Outdated
Show resolved
Hide resolved
src/Frontend/state/actions/user-settings-actions/user-settings-actions.ts
Outdated
Show resolved
Hide resolved
src/Frontend/Components/AttributionForm/AuditingOptions/AuditingOptions.util.tsx
Outdated
Show resolved
Hide resolved
src/Frontend/state/actions/user-settings-actions/__tests__/user-settings-actions.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Dominikus Hellgartner <[email protected]>
Note: Now the old signal for fetching a single backend information should be unused Signed-off-by: Dominikus Hellgartner <[email protected]>
only allow one channel to get the full user-settings information from the backend Signed-off-by: Dominikus Hellgartner <[email protected]>
… chore/user-config-handling-and-performance-fixes Conflicts: src/ElectronBackend/main/main.ts src/ElectronBackend/main/menu/viewMenu.ts src/shared/shared-types.ts
in order to avoid clashes with react naming where a provider has a fixed meaning Signed-off-by: Dominikus Hellgartner <[email protected]>
…unction Signed-off-by: Dominikus Hellgartner <[email protected]>
…e functions Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
only allow one channel to get the full user-settings information from the backend Signed-off-by: Dominikus Hellgartner <[email protected]>
Fixed bug: * User selects one of the switchable columns for ordering * User switches that column off * User clicks on Name Without the fix, the sorting direction for names would not change as expected Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
instead of multiple selectors Signed-off-by: Dominikus Hellgartner <[email protected]>
src/ElectronBackend/main/__tests__/user-settings-provider.test.ts
Outdated
Show resolved
Hide resolved
src/ElectronBackend/main/__tests__/user-settings-provider.test.ts
Outdated
Show resolved
Hide resolved
src/Frontend/state/actions/user-settings-actions/user-settings-actions.ts
Outdated
Show resolved
Hide resolved
src/Frontend/state/actions/user-settings-actions/user-settings-actions.ts
Outdated
Show resolved
Hide resolved
src/Frontend/state/actions/user-settings-actions/user-settings-actions.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Dominikus Hellgartner <[email protected]>
…or user settings Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
…s-table feat: respect settings for showing also in overview table
Signed-off-by: Dominikus Hellgartner <[email protected]>
… chore/user-config-handling-and-performance-fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff now mixes in changes for classification and criticality that in previous versions were not present. This makes it harder to do a review and I don't think any of this is intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're almost good to go now.
...tend/Components/AttributionPanels/SignalsPanel/IncludeExcludeButton/IncludeExcludeButton.tsx
Outdated
Show resolved
Hide resolved
src/Frontend/state/actions/user-settings-actions/__tests__/user-settings-actions.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Signed-off-by: Dominikus Hellgartner <[email protected]>
Summary of changes
Exchange the current setup for using electron settings in the frontend with
Context and reason for change
The current setup for the user configuration does not scale to the higher number of uses.
Using
useUserSetting
leads to a lot ofhandlers being registered. This has a few unpleasant consequences:
App.tsx
causing re-renders of the entire app on changeThis makes even handling small files hard to work with and makes the app crash on larger, more realistic, files.
How can the changes be tested
Full regression test
Note: Please review the guidelines for contributing to this repository.