luci-app-dawn: add bind address configuration for TCP connection #7661
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables binding a specific IP address for the TCP connection in the app. Signed-off-by: Nick Hainke <[email protected]>
stokito
reviewed
Mar 4, 2025
| @@ -199,6 +199,11 @@ return view.extend({ | |||
| // _('Shared key'), | |||
| // ); | |||
|
|
|||
| o = s.option(form.Value, 'tcp_ip', | |||
There was a problem hiding this comment.
I see bellow the separate tcp_port field. Maybe it can be one field something like tcp_address with type of hostport
stokito
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables binding a specific IP address for the TCP connection in the app.
Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefile