luci-app-tinyproxy: change the Bind type to list
#7223
Conversation
Signed-off-by: sasha0552 <[email protected]>
|
The app was converted to JavaScript with bbb0819 so once the PR in packages gets accepted you would need to rebase and re-implement it in JavaScript, should be trivial tho. |
| o = s:taboption("general", Value, "Bind", translate("Bind address"), | ||
| translate("Specifies the address Tinyproxy binds to for outbound forwarded requests")) | ||
| o = s:taboption("general", DynamicList, "Bind", translate("Bind address"), | ||
| translate("Specifies the addresses Tinyproxy binds to for outbound forwarded requests")) |
There was a problem hiding this comment.
I think we can leave the singular address to keep the old translations not changed. This is probably anyway covers 99% usage scenarious
There was a problem hiding this comment.
would be great if we could somehow automatically update the translations with small change like this, or even better "queue" a new translation and keep the old one until it is translated. Not sure if this can be done somehow?
There was a problem hiding this comment.
you can make sed on po files to change old key to a new to keep existing translation but this may end up with a merge conflict with translations from the Weblate. This is known problem with own issue ticket. So for a such small change I would rather recommend just not to change the translation key.
|
@Ramon00 maybe you can take finish the PR? |
|
I can make new PR I guess, but the underlaying app did not get updated yet. So we cant merge this right now anyway. |
Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefile (package does not have one?)Bindtype to list packages#24713Bindoptions, that can be used to create a proxy that (1) supports both IPv4 and IPv6 and (2) uses specific addresses (in my case VPN addresses. It is very important to bind to specific addresses to avoid traffic leaks).