Remove all of the default autoOperatorNames. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of these are generally valid for answers in PG problem and having them conflicts with units and string answers. So now there are no autoOperatorNames set by default (same as autoCommands). They can still be added if desired, and will continue to function as before if added. The LaTeX commands are now created from the `BuiltInOpNames` constant instead of constructing a new `Options` object and getting the default `autoOperatorNames` from there. That should never have been done that way anyway, and was a hack that goes back to the upstream MathQuill code. This addresses openwebwork/webwork2#2203 and openwebwork/webwork2#2681.
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Mar 7, 2025
…OperatorNames`. See openwebwork/mathquill#37. All default `autoOperatorNames` are removed to address openwebwork/webwork2#2203 and openwebwork/webwork2#2681. Any of those operators can be added back if desired, but having them by default continues to cause issues with typing other things.
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Mar 7, 2025
…OperatorNames`. See openwebwork/mathquill#37. All default `autoOperatorNames` are removed to address openwebwork/webwork2#2203 and openwebwork/webwork2#2681. Any of those operators can be added back if desired, but having them by default continues to cause issues with typing other things.
pstaabp
approved these changes
Mar 11, 2025
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Mar 12, 2025
…OperatorNames`. See openwebwork/mathquill#37. All default `autoOperatorNames` are removed to address openwebwork/webwork2#2203 and openwebwork/webwork2#2681. Any of those operators can be added back if desired, but having them by default continues to cause issues with typing other things.
Alex-Jordan
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these are generally valid for answers in PG problem and having them conflicts with units and string answers. So now there are no autoOperatorNames set by default (same as autoCommands). They can still be added if desired, and will continue to function as before if added.
The LaTeX commands are now created from the
BuiltInOpNamesconstant instead of constructing a newOptionsobject and getting the defaultautoOperatorNamesfrom there. That should never have been done that way anyway, and was a hack that goes back to the upstream MathQuill code.This addresses openwebwork/webwork2#2203 and openwebwork/webwork2#2681.