Skip longjmp() SEH unwind in 64-bit build
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't specifying the include and library paths in cppflags/ldflags, requiring each build system invocation to specify them individually. As a result, we weren't specifying -I to cmake or either path to zlib or iconv. Centralize path setting in cppflags/ldflags. Signed-off-by: Benjamin Gilbert <[email protected]>
On 64-bit Windows, MinGW passes a frame pointer to _setjmp so longjmp can do a SEH unwind. This seems to work when the caller is also built with MinGW, but sometimes crashes with STATUS_BAD_STACK when the caller is built with MSVC; it appears that this is a longstanding MinGW issue. In 64-bit builds, override setjmp() to pass a NULL frame pointer to skip the SEH unwind. Our uses of setjmp/longjmp are all in libpng/libjpeg error handling, which isn't expecting to do any cleanup in intermediate stack frames, so this should be fine. Fixes openslide#47. Signed-off-by: Benjamin Gilbert <[email protected]>
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
This was referenced Aug 6, 2022
bgilbert
added a commit
to bgilbert/openslide
that referenced
this pull request
Aug 7, 2022
We're no longer trying to strictly comply with C99, since we're now dependent on the GCC/clang cleanup attribute. Regardless, the GCC docs say -pedantic doesn't issue diagnostics for all deviations from the C standard, so we can't assume that use of the option enforces compliance. We already enable -Wall and -Wextra, so let's stick to those, rather than asking for warnings the compiler thinks are dubious. This makes -Wno-pedantic-ms-format unnecessary, so drop it. This was originally motivated by openslide-winbuild's use of #include_next in openslide/openslide-bin#49, coupled with the use of -Werror in CI.
bgilbert
added a commit
to bgilbert/openslide
that referenced
this pull request
Aug 7, 2022
We're no longer trying to strictly comply with C99, since we're now dependent on the GCC/clang cleanup attribute. Regardless, the GCC docs say -pedantic doesn't issue diagnostics for all deviations from the C standard, so we can't assume that use of the option enforces compliance. We already enable -Wall and -Wextra, so let's stick to those, rather than asking for warnings the compiler thinks are dubious. This makes -Wno-pedantic-ms-format unnecessary, so drop it. This was originally motivated by openslide-winbuild's use of #include_next in openslide/openslide-bin#49, coupled with the use of -Werror in CI. Signed-off-by: Benjamin Gilbert <[email protected]>
This was referenced Aug 7, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 64-bit Windows, MinGW passes a frame pointer to
_setjmpsolongjmpcan do a SEH unwind. This seems to work when the caller is also built with MinGW, but sometimes crashes withSTATUS_BAD_STACKwhen the caller is built with MSVC; it appears that this is a longstanding MinGW issue. In 64-bit builds, overridesetjmp()to pass aNULLframe pointer to skipthe SEH unwind. Our uses of
setjmp/longjmpare all in libpng/libjpeg error handling, which isn't expecting to do any cleanup in intermediate stack frames, so this should be fine.Fixes #47.