OSD-24997: Show if a user is banned when using osdctl cluster context #671
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@Mhodesty: This pull request references OSD-24997 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -734,6 +759,21 @@ func printDynatraceResources(data *contextData) { | |||
| } | |||
| } | |||
|
|
|||
| func printUserBannedStatus(data *contextData) { | |||
| var name string = "User Ban Details" | |||
| fmt.Println("\n" + delimiter + name) | |||
There was a problem hiding this comment.
Are we always using fmt.Println already above? If so this is adding an extra \n between the last printed text and this.
There was a problem hiding this comment.
Hi JB.
https://redhat-internal.slack.com/archives/CCX9DB894/p1739809796051329
Here's a thread with the output on a cluster where a user is banned. See Jim's comment from 12:01 Saturday. I've also pasted the output as it shows in the command in the code block below.
This adds an extra \n between "User Ban Details" and "User is banned" or "User is not banned" increasing readability.
>> User Ban Details
User is banned
Ban code = pending
Ban description = pending
There was a problem hiding this comment.
I more meant the full command output of osdctl cluster context $CLUSTER_ID to see if there is an extra newline
There was a problem hiding this comment.
Sure. Here's the output of the osdctl command run on a cluster. I redacted the cluster identifying information but the output looks clean to me.
>> PagerDuty Alerts
Service: [Redacted]
None
>> External resources
CCX dashboard [Redacted]
OHSS Cards [Redacted]
PagerDuty Service [Redacted]
Splunk Audit Logs [Redacted]
>> Dynatrace Details
Not an HCP or MC Cluster
>> User Ban Details
User is not banned
|
@Mhodesty: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joshbranham, Mhodesty The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This PR adds output to osdctl cluster context to show if a user is banned. The goal is to cut down on SRE toil time by showing this information at the beginning of the troubleshooting process. Output looks like this