Maint: remove dependency on "oc" for the osdctl hcp must-gather command #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This client helps you develop, build, deploy, and run your applications on any OpenShift or Kubernetes cluster. It also includes the administrative commands for managing a cluster under the 'adm' subcommand. Basic Commands: login Log in to a server new-project Request a new project new-app Create a new application status Show an overview of the current project project Switch to another project projects Display existing projects explain Get documentation for a resource Build and Deploy Commands: rollout Manage a Kubernetes deployment or OpenShift deployment config rollback Revert part of an application back to a previous deployment new-build Create a new build configuration start-build Start a new build cancel-build Cancel running, pending, or new builds import-image Import images from a container image registry tag Tag existing images into image streams Application Management Commands: create Create a resource from a file or from stdin apply Apply a configuration to a resource by file name or stdin get Display one or many resources describe Show details of a specific resource or group of resources edit Edit a resource on the server set Commands that help set specific features on objects label Update the labels on a resource annotate Update the annotations on a resource expose Expose a replicated application as a service or route delete Delete resources by file names, stdin, resources and names, or by resources and label selector scale Set a new size for a deployment, replica set, or replication controller autoscale Autoscale a deployment config, deployment, replica set, stateful set, or replication controller secrets Manage secrets Troubleshooting and Debugging Commands: logs Print the logs for a container in a pod rsh Start a shell session in a container rsync Copy files between a local file system and a pod port-forward Forward one or more local ports to a pod debug Launch a new instance of a pod for debugging exec Execute a command in a container proxy Run a proxy to the Kubernetes API server attach Attach to a running container run Run a particular image on the cluster cp Copy files and directories to and from containers wait Experimental: Wait for a specific condition on one or many resources events List events Advanced Commands: adm Tools for managing a cluster replace Replace a resource by file name or stdin patch Update fields of a resource process Process a template into list of resources extract Extract secrets or config maps to disk observe Observe changes to resources and react to them (experimental) policy Manage authorization policy auth Inspect authorization image Useful commands for managing images registry Commands for working with the registry idle Idle scalable resources api-versions Print the supported API versions on the server, in the form of "group/version" api-resources Print the supported API resources on the server cluster-info Display cluster information diff Diff the live version against a would-be applied version kustomize Build a kustomization target from a directory or URL Settings Commands: get-token Experimental: Get token from external OIDC issuer as credentials exec plugin logout End the current server session config Modify kubeconfig files whoami Return information about the current session completion Output shell completion code for the specified shell (bash, zsh, fish, or powershell) Other Commands: plugin Provides utilities for interacting with plugins version Print the client and server version information Usage: oc [flags] [options] Use "oc <command> --help" for more information about a given command. Use "oc options" for a list of global command-line options (applies to all commands). for osdctl hcp must-gather
openshift-ci
bot
added
the
approved
|
@typeid: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devppratik, typeid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on
oc, used for programmatic must-gathers and opts for shelling out instead.Additionally, this PR adds a flag to allow overriding the ACM must-gather image.
Reasoning:
oc rsync.We had to hack around this by overriding the shell out with a specific kubeconfig.go list, see Replace defunct package brought in by importing 'oc' #665.