OSD-24614 : Update osdctl to add justification arguement for infranode resize #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitaliBhalla
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
MitaliBhalla
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
devppratik
reviewed
Jul 17, 2024
Comment on lines
+35
to
36
| resizedInfraNodeServiceLogTemplate = "https://raw.githubusercontent.com/openshift/managed-notifications/master/osd/infranode_resized.json" | ||
| GCPresizedInfraNodeServiceLogTemplate = "https://raw.githubusercontent.com/openshift/managed-notifications/master/osd/gcp/GCP_infranode_resized_auto.json" |
There was a problem hiding this comment.
/hold
Waiting until the service log are properly updated
There was a problem hiding this comment.
Done via openshift/managed-notifications#327
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test lint |
devppratik
reviewed
Jul 17, 2024
cmd/cluster/resize/infra_node.go
Outdated
| if mp.Spec.Platform.AWS != nil { | ||
| return servicelog.PostCmdOptions{ | ||
| Template: resizedInfraNodeServiceLogTemplate, | ||
| ClusterId: clusterId, | ||
| TemplateParams: []string{fmt.Sprintf("INSTANCE_TYPE=%s", instanceType)}, | ||
| TemplateParams: []string{fmt.Sprintf("INSTANCE_TYPE=%s", instanceType),fmt.Sprintf("JUSTIFICATION=%s", justification)}, |
There was a problem hiding this comment.
Suggested change
| TemplateParams: []string{fmt.Sprintf("INSTANCE_TYPE=%s", instanceType),fmt.Sprintf("JUSTIFICATION=%s", justification)}, | |
| TemplateParams: []string{fmt.Sprintf("INSTANCE_TYPE=%s", instanceType), fmt.Sprintf("JUSTIFICATION=%s", justification)}, |
cmd/cluster/resize/infra_node.go
Outdated
| } | ||
| } else if mp.Spec.Platform.GCP != nil { | ||
| return servicelog.PostCmdOptions{ | ||
| Template: GCPresizedInfraNodeServiceLogTemplate, | ||
| ClusterId: clusterId, | ||
| TemplateParams: []string{fmt.Sprintf("INSTANCE_TYPE=%s", instanceType)}, | ||
| TemplateParams: []string{fmt.Sprintf("INSTANCE_TYPE=%s", instanceType),fmt.Sprintf("JUSTIFICATION=%s", justification)}, |
There was a problem hiding this comment.
Suggested change
| TemplateParams: []string{fmt.Sprintf("INSTANCE_TYPE=%s", instanceType),fmt.Sprintf("JUSTIFICATION=%s", justification)}, | |
| TemplateParams: []string{fmt.Sprintf("INSTANCE_TYPE=%s", instanceType), fmt.Sprintf("JUSTIFICATION=%s", justification)}, |
|
/label tide/merge-method-squash |
openshift-ci
bot
added
the
tide/merge-method-squash
|
@MitaliBhalla: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devppratik, MitaliBhalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current infra node resize SL does mention about the justification of the resize, . However, in our [SOP] (https://github.com/openshift/ops-sop/blob/master/v4/alerts/InfraNodesNeedResizingSRE.md) , the command mentioned doesn't mention about the justification arguement as osdctl refers to other SL that doesn't have the justification arguement. https://github.com/openshift/osdctl/blob/master/cmd/cluster/resize/infra_node.go#L35C43-L35C147
This PR incorporates for :