Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mce-2.4] HIVE-2787: CVE-2025-22868 x/oauth2/jws => 0.26.openshift.1 #2603

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

2uasimojo
Copy link
Member

@2uasimojo 2uasimojo commented Mar 14, 2025

Replace x/oauth2 with the openshift fork containing the fix. (The upstream fix in 0.27.0 requires golang 1.23, and bumping in this release would be Hard™.)

https://security.snyk.io/vuln/SNYK-GOLANG-GOLANGORGXOAUTH2JWS-8749594

ACM-18179

(cherry picked from commit 270568c)

Replace x/oauth2 with the openshift fork containing the fix. (The
upstream fix in 0.27.0 requires golang 1.23, and bumping in this release
would be Hard™.)

https://security.snyk.io/vuln/SNYK-GOLANG-GOLANGORGXOAUTH2JWS-8749594

ACM-18179

(cherry picked from commit 270568c)
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2025

@2uasimojo: This pull request references HIVE-2787 which is a valid jira issue.

In response to this:

Replace x/oauth2 with the openshift fork containing the fix. (The upstream fix in 0.27.0 requires golang 1.23, and bumping in this release would be Hard™.)

https://security.snyk.io/vuln/SNYK-GOLANG-GOLANGORGXOAUTH2JWS-8749594

ACM-18179

(cherry picked from commit 270568c)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2025
@openshift-ci openshift-ci bot requested review from jstuever and suhanime March 14, 2025 21:46
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.64%. Comparing base (39c37dc) to head (b647e53).
Report is 2 commits behind head on mce-2.4.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           mce-2.4    #2603   +/-   ##
========================================
  Coverage    57.64%   57.64%           
========================================
  Files          186      186           
  Lines        25839    25839           
========================================
  Hits         14894    14894           
  Misses        9699     9699           
  Partials      1246     1246           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@2uasimojo
Copy link
Member Author

/override ci/prow/security

Crypto being addressed via HIVE-2786.

The other requires a k8s bump, which isn't happening in this branch.

@2uasimojo
Copy link
Member Author

/assign @suhanime

Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

In response to this:

/override ci/prow/security

Crypto being addressed via HIVE-2786.

The other requires a k8s bump, which isn't happening in this branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@suhanime
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025
Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 39c37dc and 2 for PR HEAD b647e53 in total

@2uasimojo
Copy link
Member Author

/override ci/prow/security

Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@2uasimojo
Copy link
Member Author

Not sure what's happening with prow here. I'm gonna mash the merge button. No sense retesting -- nothing else has happened in this branch.

@2uasimojo 2uasimojo merged commit 3fef351 into openshift:mce-2.4 Mar 17, 2025
7 of 8 checks passed
@2uasimojo 2uasimojo deleted the HIVE-2787/mce-2.4/cve-oauth2 branch March 17, 2025 18:45
Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

@2uasimojo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security b647e53 link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants