Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origins information in RecipeDescriptor #5162

Merged
merged 28 commits into from
Mar 24, 2025
Merged

Conversation

MBoegers
Copy link
Contributor

@MBoegers MBoegers commented Mar 12, 2025

What's changed?

The Enviroment loads the GitHub URL and LIcense information per Recipe from provided resources. The resouces are generated here openrewrite/rewrite-build-gradle-plugin#83.

What's your motivation?

The Documentation uses a heuristic approach to determine which the GitHub URL and correct license information.

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@MBoegers MBoegers self-assigned this Mar 12, 2025
@MBoegers MBoegers added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 12, 2025
github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@jevanlingen jevanlingen marked this pull request as ready for review March 24, 2025 08:56
github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as off-topic.

github-actions[bot]

This comment was marked as off-topic.

@jevanlingen jevanlingen merged commit 68de1e0 into main Mar 24, 2025
2 checks passed
@jevanlingen jevanlingen deleted the cr/879-license-info-in-recipe branch March 24, 2025 14:23
MBoegers added a commit that referenced this pull request Mar 25, 2025
MBoegers added a commit that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants