Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer sidebar: Add ability to search and pin widgets #3110

Merged
merged 2 commits into from
Mar 22, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Mar 16, 2025

No description provided.

@jimtng jimtng requested review from ghys and florian-h05 as code owners March 16, 2025 00:36
@jimtng jimtng force-pushed the sidebar-search-widgets branch from 270cb1b to 4c1797d Compare March 16, 2025 00:44
Copy link

relativeci bot commented Mar 16, 2025

#2935 Bundle Size — 11.08MiB (+0.03%).

95af0d9(current) vs f193ef9 main#2932(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2935
     Baseline
#2932
No change  Initial JS 2MiB 2MiB
No change  Initial CSS 577.34KiB 577.34KiB
Change  Cache Invalidation 18.28% 18.8%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2949 2949
No change  Duplicate Modules 150 150
No change  Duplicate Code 1.72% 1.72%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2935
     Baseline
#2932
Regression  JS 9.29MiB (+0.03%) 9.29MiB
No change  CSS 867.35KiB 867.35KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:sidebar-search-widgetsProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
One minor comment I will handle myself.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Mar 22, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Mar 22, 2025
@florian-h05 florian-h05 changed the title Developer Sidebar: Add ability to search and pin widgets Developer sidebar: Add ability to search and pin widgets Mar 22, 2025
@florian-h05 florian-h05 merged commit d48aecf into openhab:main Mar 22, 2025
5 checks passed
@jimtng jimtng deleted the sidebar-search-widgets branch March 23, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants