Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idtools: return errors for >u32 specification #558

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

cyphar
Copy link
Member

@cyphar cyphar commented Nov 28, 2024

This isn't a huge issue, but it could cause user confusion if they
provide too large a value.

Signed-off-by: Aleksa Sarai [email protected]

This isn't a huge issue, but it could cause user confusion if they
provide too large a value.

Signed-off-by: Aleksa Sarai <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.70%. Comparing base (71d012d) to head (e597e6a).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   73.68%   73.70%   +0.01%     
==========================================
  Files          60       60              
  Lines        4903     4906       +3     
==========================================
+ Hits         3613     3616       +3     
  Misses        941      941              
  Partials      349      349              
Files with missing lines Coverage Δ
pkg/idtools/idtools.go 100.00% <100.00%> (ø)

@tych0 tych0 merged commit 3974679 into opencontainers:main Nov 28, 2024
16 checks passed
@cyphar cyphar deleted the idtools-u32-errors branch November 28, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants