Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added package-lock back #186

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Added package-lock back #186

merged 3 commits into from
Mar 16, 2023

Conversation

ajzkk
Copy link
Contributor

@ajzkk ajzkk commented Mar 16, 2023

  • Added package-lock.json back which is generated with node version 12.x
  • Update Promise example code

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@danfowler
Copy link
Contributor

Fixes #179

@danfowler danfowler self-requested a review March 16, 2023 02:17
@@ -145,11 +145,11 @@ omise.tokens.retrieve('tokn_test_4xs9408a642a1htto8z', function(error, token) {

// This function will be called after a charge is created.

}).error(function(err) {
}).then(function(err) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajzkk should we bump the major version?

@danfowler danfowler self-requested a review March 16, 2023 02:30
@ajzkk ajzkk merged commit 925d0a9 into master Mar 16, 2023
@ajzkk ajzkk deleted the added-lockfile-back branch March 21, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants