Refactor: reduce visibility of fields and optimize sorting logic. #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated variable modifiers to align with best practices, improving encapsulation in `ProjectFilesList.form` and `ProjectFilesList.java`. Simplified sorting logic in `ProjectFilesListController.java` by leveraging utility methods for cleaner and more efficient code. Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
- Streamlined `DataTableStyling` with new factory methods and static imports. - Merged and relocated key listener filtering logic to improve encapsulation in `ProjectFilesListController`. - Enhanced code clarity by removing unnecessary methods and redundant constructors. - Add javadoc for FilesTableColumn enum Signed-off-by: Hiroshi Miura <[email protected]>
|
❌ Quality checks failed. Please look a Gradle Scan page for details: |
miurahr
changed the title
Reorganize imports to explicitly reference specific elements from DataTableStyling, improving code clarity and readability. This change reduces ambiguity and simplifies navigating related static references in the file. Signed-off-by: Hiroshi Miura <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pull Request (PR) involves the enhancement of code readability and refinement of data handling by modifying field access levels, optimizing syntax, and introducing auxiliary values in the GUI .form setup.
Main changes:
Field Access Levels Updated: Changes were made in ProjectFilesList.java to modify field access levels (e.g., public to private) for better encapsulation and object-oriented design practices.
Sorting Logic Simplified and Optimized: Adjustments in ProjectFilesListController.java include replacing verbose sorting logic with more concise methods like Integer.compare.
Removal of Redundant Imports: Refactored unnecessary imports to streamline dependencies in the code.
GUI .form Updates: Added AuxValues elements to the ProjectFilesList.form file, likely for additional GUI-related metadata and customization.
Updated variable modifiers to align with best practices, improving encapsulation in
ProjectFilesList.formandProjectFilesList.java. Simplified sorting logic inProjectFilesListController.javaby leveraging utility methods for cleaner and more efficient code.Pull request type
Please mark github LABEL of the type of change your PR introduces:
Which ticket is resolved?
What does this PR change?
ProjectFilesList.formandProjectFilesList.java. Simplified sorting logic inProjectFilesListController.javaby leveraging utility methods for cleaner and more efficient code.Other information
#1296