Refactor AlignPanelController to take Aligner as a method parameter
#1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes `Aligner` as a field in `AlignPanelController` and refactors related methods to accept it as a parameter instead. This improves encapsulation by limiting the scope of the `Aligner` object to where it is needed. It simplifies the controller's responsibilities, making it cleaner and less coupled. Signed-off-by: Hiroshi Miura <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes
Aligneras a field inAlignPanelControllerand refactors related methods to accept it as a parameter instead. This improves encapsulation by limiting the scope of theAlignerobject to where it is needed. It simplifies the controller's responsibilities, making it cleaner and less coupled.Pull request type
Please mark github LABEL of the type of change your PR introduces:
refactoring to fix spotbugs error
Which ticket is resolved?
What does this PR change?
Other information