Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all usage of sha library in favor of hashlib #454

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Mar 21, 2025

The hashlib module has been part of the Python standard library since Python 2.5. This PR cleans up several import fallbacks to its sha predecessor.

This is primarily a maintenance contribution, the dropped code paths should no longer be functional. All integration tests are expected to keep passing with this change included

@sbesson sbesson requested a review from jburel March 21, 2025 09:11
@sbesson sbesson closed this Mar 21, 2025
@sbesson sbesson reopened this Mar 21, 2025
@sbesson sbesson added this to the 5.19.7 milestone Mar 21, 2025
@sbesson sbesson merged commit 88b24c5 into ome:master Mar 27, 2025
24 checks passed
@sbesson sbesson deleted the hashlib_import_cleanup branch March 27, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants