Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Carthage by adding xcodeproj in the root directory. #36

Merged
merged 3 commits into from
Dec 4, 2022

Conversation

wrutkowski-tyro
Copy link
Contributor

Hello, thanks for creating this library! I'd like to use it with Carthage so I created a branch that supports Carthage. Basic requirement is to have a Xcodeproj in the root directory which I created using xcodegen and I checked in project.yml so it should be easy to recreate the Xcode project again if needed. I had to provide bundle identifier so I picked com.github.oleghnidets. Let me know if you are happy with this change.

@oleghnidets
Copy link
Owner

Hi @wrutkowski-tyro!
Thank you for great contribution.

Carthage is awesome improvement to this library. I definitely like to see it supported. I will check the changes in couple of days.
Did you integrate the library from the branch? Is it working fine with Carthage?

@wrutkowski-tyro
Copy link
Contributor Author

Yes, we integrated it to our project using carthage and (for now) using my fork as a reference. It's working as expected.

Cartfile:

github "wrutkowski-tyro/OHMySQL" "carthage-support"

carthage update:

❯ carthage update --platform iOS --use-xcframeworks OHMySQL
*** Fetching OHMySQL
*** Checking out OHMySQL at "acfb90f443c34b802e0d12f9df08898bf6f19eaa"
*** xcodebuild output can be found in /var/folders/rl/bncglbnj2pgbyjnbp54qsvbd2dfnjy/T/carthage-xcodebuild.ZXcbZI.log
*** Building scheme "OHMySQL" in OHMySQL.xcodeproj

The only manual step required to integrate except dropping xcframework of OHMySQL from Carthage/Build folder was to manually add MySQL.xcframework that's part of your repo. Carthage doesn't have a support for dependency that's part of the same repository to move the MySQL.xcframework to the Build folder.

@oleghnidets
Copy link
Owner

Hey @wrutkowski-tyro
I like this PR, but I wish to have this improvement documented.

Could you create a documentation (*.md) in docs folder? Describe there how to configure xcodegen to generate projects.
I'm going to update documentation in near future, so I will have a reference to your documentation.
Thanks

@wrutkowski-tyro
Copy link
Contributor Author

Hi @oleghnidets 👋 I added documentation as requested.

@oleghnidets oleghnidets merged commit 2f041f3 into oleghnidets:master Dec 4, 2022
@wrutkowski-tyro
Copy link
Contributor Author

Thanks for merging @oleghnidets 👏 Would you be able to create a tag / release so we can start using master instead of the fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants