-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSX API #254
Add JSX API #254
Conversation
`<div> ...children </div>` or `<div> ...{f()} </div>` were not supported.
02c4e18
to
8c0aa70
Compare
Alright, the tests finally pass.
Current issues:
|
I added the toggle. The syntax is @Khady I'm highly tempted to change the antiquotes so that in |
Hmm I’m probably not the best person to ask as I’m not using jsx extensively. But I tend to believe that I prefer the current setup.
- it is weird that “bar” is accepted and is a single element but others must be a list
- most of the time we don’t have a list of elements from what I gathered in our code
- when I write some HTML or use other template systems, each “element” is one element, not a list
- I feel that using ...others once in a while is less heavy than using [other] all the time
|
I think keeping somewhat close to the react ppx would be preferable. I would rather have to spread a list than always wrap things with lists. |
My issue is that the spread operator is only available if it's the only child. You can't write |
Everything's green, let's merge the current version! I kept the antiquotations as before. @Khady @ulrikstrid I'll let you test this for a week. If someone's motivated to write a reason-inclined documentation, I would appreciate it as well ^^' |
CHANGES: * Add support for Reason's JSX syntax with a new `tyxml-jsx` package (ocsigen/tyxml#254 by Joris Giovannangeli and Gabriel Radanne with help from Ulrik Strid and Louis Roché) * Modernize the handling of toplevel printers for utop. (Gabriel Radanne) ## Elements and attributes * Add `allowfullscreen`, `allowpaymentrequest`, `referrerpolicy` attributes (ocsigen/tyxml#242 by Thibault Suzanne) * Allow `crossorigin` attribute for script element (ocsigen/tyxml#243 by Thibault Suzanne) * Greatly improved support of whitespaces in the PPX (ocsigen/tyxml#225 by Jules Aguillon) * Add preliminary support for ARIA attributes (ocsigen/tyxml#253 by Stéphane Legrand and Gabriel Radanne) * Add `template` element (ocsigen/tyxml#239 Stéphane Legrand) * Several bug fixes for types and PPX
CHANGES: * Add support for Reason's JSX syntax with a new `tyxml-jsx` package (ocsigen/tyxml#254 by Joris Giovannangeli and Gabriel Radanne with help from Ulrik Strid and Louis Roché) * Modernize the handling of toplevel printers for utop. (Gabriel Radanne) ## Elements and attributes * Add `allowfullscreen`, `allowpaymentrequest`, `referrerpolicy` attributes (ocsigen/tyxml#242 by Thibault Suzanne) * Allow `crossorigin` attribute for script element (ocsigen/tyxml#243 by Thibault Suzanne) * Greatly improved support of whitespaces in the PPX (ocsigen/tyxml#225 by Jules Aguillon) * Add preliminary support for ARIA attributes (ocsigen/tyxml#253 by Stéphane Legrand and Gabriel Radanne) * Add `template` element (ocsigen/tyxml#239 Stéphane Legrand) * Several bug fixes for types and PPX
CHANGES: * Add support for Reason's JSX syntax with a new `tyxml-jsx` package (ocsigen/tyxml#254 by Joris Giovannangeli and Gabriel Radanne with help from Ulrik Strid and Louis Roché) * Modernize the handling of toplevel printers for utop. (Gabriel Radanne) ## Elements and attributes * Add `allowfullscreen`, `allowpaymentrequest`, `referrerpolicy` attributes (ocsigen/tyxml#242 by Thibault Suzanne) * Allow `crossorigin` attribute for script element (ocsigen/tyxml#243 by Thibault Suzanne) * Greatly improved support of whitespaces in the PPX (ocsigen/tyxml#225 by Jules Aguillon) * Add preliminary support for ARIA attributes (ocsigen/tyxml#253 by Stéphane Legrand and Gabriel Radanne) * Add `template` element (ocsigen/tyxml#239 Stéphane Legrand) * Several bug fixes for types and PPX
Follow up of #247
cc @Khady @jorisgio @ulrikstrid