Make the ppx work with wrapped APIs. #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vasilisp I added a test for attributes that use wrapped functions, so I believe it should also work with eliom's shared dom (and all its fancy variations). Can you give it a shot? |
|
@Drup thanks, I promise to try it out in the next few days! |
|
I just noticed, this is issue n°200, 🎉 |
Drup
added a commit
to Drup/opam-repository
that referenced
this pull request
Nov 18, 2018
CHANGES: * Dunify This also removes all the deprecated libraries (`tyxml.syntax`, `tyxml.parser`) and removes the ocamlfind library `tyxml.ppx` in favor of `tyxml-ppx`. (ocsigen/tyxml#197 by Drup, Rudi Grinberg and Anton Bachin) * Add simplistic indentation for the Format-based printer (ocsigen/tyxml#187 by Drup) * Allow the ppx to be used for more exotic tyxml instances, such as reactive elements (ocsigen/tyxml#200 by Drup) * Add `Html.of_seq` and `Svg.of_seq`, which allow to easily import HTML parsed with markup in TyXML (ocsigen/tyxml#221 by Drup) ## Elements and attributes * Add Html.txt and Svg.txt as an alias for `pcdata` (ocsigen/tyxml#222 by Drup) * Add noopener link types (ocsigen/tyxml#198 by Jérôme Vouillon) * Slightly relax dt content type (ocsigen/tyxml#193 by Anton Bachin) * Add touch events (ocsigen/tyxml#211 by Malthe Borch) * Fix handling of figcaption in the PPX (ocsigen/tyxml#219 by Drup)
Drup
added a commit
to Drup/opam-repository
that referenced
this pull request
Nov 18, 2018
CHANGES: * Dunify This also removes all the deprecated libraries (`tyxml.syntax`, `tyxml.parser`) and removes the ocamlfind library `tyxml.ppx` in favor of `tyxml-ppx`. (ocsigen/tyxml#197 by Drup, Rudi Grinberg and Anton Bachin) * Add simplistic indentation for the Format-based printer (ocsigen/tyxml#187 by Drup) * Allow the ppx to be used for more exotic tyxml instances, such as reactive elements (ocsigen/tyxml#200 by Drup) * Add `Html.of_seq` and `Svg.of_seq`, which allow to easily import HTML parsed with markup in TyXML (ocsigen/tyxml#221 by Drup) ## Elements and attributes * Add Html.txt and Svg.txt as an alias for `pcdata` (ocsigen/tyxml#222 by Drup) * Add noopener link types (ocsigen/tyxml#198 by Jérôme Vouillon) * Slightly relax dt content type (ocsigen/tyxml#193 by Anton Bachin) * Add touch events (ocsigen/tyxml#211 by Malthe Borch) * Fix handling of figcaption in the PPX (ocsigen/tyxml#219 by Drup)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was somehow convinced that this was working already, but apparenty it didn't.
I extended the test cases to cover wrapped APIs and I fixed a few bugs.
After this patch, this works:
and yields a completely reactive webpage. ❤️