Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImGuiWindowFlags_UnsavedDocument no longer shows up when window is docked #8430

Closed
jvannugteren opened this issue Feb 24, 2025 · 2 comments
Closed
Labels
bug tabs tab bars, tabs

Comments

@jvannugteren
Copy link

Version/Branch of Dear ImGui:

Docking

Back-ends:

Magnum

Compiler, OS:

Linux

Full config/build information:

No response

Details:

In the current docking branch the behavior of the ImGuiWindowFlags_UnsavedDocument tag changed. It no longer shows up when a window is docked and active. Instead the marker is overriden with the X, even when the button is not mouse-overed. See screenshots below. Thank you for having a look.

Screenshots/Video:

Old correct behaviour from v1.91.8-docking:
Image

New regressed behaviour from docking branch:
Image
The X-Mark is overrides the ImGuiWindowFlags_UnsavedDocument marker.

Minimal, Complete and Verifiable Example code:

static bool window_open = true;
if(ImGui::Begin("Dock This", &window_open, ImGuiWindowFlags_UnsavedDocument)){
ImGui::Text("dock this window and the unsaved document tag will disappear");
}
ImGui::End();

@ocornut ocornut added tabs tab bars, tabs bug labels Feb 24, 2025
@ocornut
Copy link
Owner

ocornut commented Feb 24, 2025

Caused by the changes on Feb 12 for #8387, will fix now. Thanks for reporting!

@ocornut
Copy link
Owner

ocornut commented Feb 24, 2025

Pushed fix ef969a5. It's currently on master but I verified that you can cherry-pick it on docking if you need the fix right away.
Apologies for the regression!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tabs tab bars, tabs
Projects
None yet
Development

No branches or pull requests

2 participants