-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Improve deriving inline so it can be used alongside other ppx-es #541
base: main
Are you sure you want to change the base?
Conversation
CC @mbarbin you should be able to try this out for your usecase, simply add the This is still WIP as I'm trying to tie all loose ends but it should already be usable for common use cases. |
b51d33e
to
4b77038
Compare
Hi @NathanReb I wanted to let you know that it will take me a bit of time to get back to you on this, but I am excited to try it out as soon as I get a chance. Thank you for your work on this! |
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
4b77038
to
6426dc0
Compare
@NathanReb I tried it in this PR => mbarbin/vcs#32 and commented there directly. To summarize what I got:
So, this is definitely a lot of progress, and possibly very close to working! Thanks a lot. |
@mbarbin is this something you are still interested in? |
Hi @NathanReb thanks for asking! Yes absolutely. I didn't want to be a distraction from all the amazing work you guys did for OCaml 5.2 ast migration, and the support for effect syntax (which I tried with 0.35, and it worked very nicely), but sure this is something I'd be very keen on seeing progressing in the long run. I did a little pass over this and summarize below the tickets which I think are linked to this scope of work. Please let me know if you agree, and if I have forgotten something: ocaml/dune#2992 Thank you! |
Great to hear, I'll resume working on this! |
No description provided.